This patch fixes a bug in kprobes that can cause an Oops or even a crash when a return probe is installed on one of the following functions: sys_execve, do_execve, load_*_binary, flush_old_exec, or flush_thread. The fix is to remove the call to kprobe_flush_task() in flush_thread(). --- arch/i386/kernel/process.c | 7 ------- arch/ia64/kernel/process.c | 7 ------- arch/powerpc/kernel/process.c | 1 - arch/x86_64/kernel/process.c | 7 ------- 4 files changed, 22 deletions(-) diff -puN arch/i386/kernel/process.c~kretprobes-exec arch/i386/kernel/process.c --- linux-2.6.15-rc2/arch/i386/kernel/process.c~kretprobes-exec 2005-11-21 13:32:59.000000000 -0800 +++ linux-2.6.15-rc2-jimk/arch/i386/kernel/process.c 2005-11-21 13:33:25.000000000 -0800 @@ -393,13 +393,6 @@ void flush_thread(void) { struct task_struct *tsk = current; - /* - * Remove function-return probe instances associated with this task - * and put them back on the free list. Do not insert an exit probe for - * this function, it will be disabled by kprobe_flush_task if you do. - */ - kprobe_flush_task(tsk); - memset(tsk->thread.debugreg, 0, sizeof(unsigned long)*8); memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array)); /* diff -puN arch/ia64/kernel/process.c~kretprobes-exec arch/ia64/kernel/process.c --- linux-2.6.15-rc2/arch/ia64/kernel/process.c~kretprobes-exec 2005-11-21 13:32:59.000000000 -0800 +++ linux-2.6.15-rc2-jimk/arch/ia64/kernel/process.c 2005-11-21 13:33:25.000000000 -0800 @@ -718,13 +718,6 @@ kernel_thread_helper (int (*fn)(void *), void flush_thread (void) { - /* - * Remove function-return probe instances associated with this task - * and put them back on the free list. Do not insert an exit probe for - * this function, it will be disabled by kprobe_flush_task if you do. - */ - kprobe_flush_task(current); - /* drop floating-point and debug-register state if it exists: */ current->thread.flags &= ~(IA64_THREAD_FPH_VALID | IA64_THREAD_DBG_VALID); ia64_drop_fpu(current); diff -puN arch/powerpc/kernel/process.c~kretprobes-exec arch/powerpc/kernel/process.c --- linux-2.6.15-rc2/arch/powerpc/kernel/process.c~kretprobes-exec 2005-11-21 13:32:59.000000000 -0800 +++ linux-2.6.15-rc2-jimk/arch/powerpc/kernel/process.c 2005-11-21 13:33:25.000000000 -0800 @@ -457,7 +457,6 @@ void flush_thread(void) if (t->flags & _TIF_ABI_PENDING) t->flags ^= (_TIF_ABI_PENDING | _TIF_32BIT); #endif - kprobe_flush_task(current); #ifndef CONFIG_SMP if (last_task_used_math == current) diff -puN arch/x86_64/kernel/process.c~kretprobes-exec arch/x86_64/kernel/process.c --- linux-2.6.15-rc2/arch/x86_64/kernel/process.c~kretprobes-exec 2005-11-21 13:32:59.000000000 -0800 +++ linux-2.6.15-rc2-jimk/arch/x86_64/kernel/process.c 2005-11-21 13:33:25.000000000 -0800 @@ -351,13 +351,6 @@ void flush_thread(void) struct task_struct *tsk = current; struct thread_info *t = current_thread_info(); - /* - * Remove function-return probe instances associated with this task - * and put them back on the free list. Do not insert an exit probe for - * this function, it will be disabled by kprobe_flush_task if you do. - */ - kprobe_flush_task(tsk); - if (t->flags & _TIF_ABI_PENDING) t->flags ^= (_TIF_ABI_PENDING | _TIF_IA32); _